Skip to content

rbac: application edit #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

rbac: application edit #827

wants to merge 2 commits into from

Conversation

@jtriley
Copy link
Contributor

@jtriley jtriley commented Nov 14, 2025

This allows users to manage applications.app.k8s.io resources within their namespace via a new ClusterRole, aggregate-edit, that aggregates to the edit ClusterRole.

@jtriley
rbac: add application-edit clusterrole
a471eff 
This is a ClusterRole that allows full access to application.app.k8s.io
resources and aggregates to the edit ClusterRole.
@jtriley
ocp-test: add application-edit clusterrole
a36ff70
larsks
larsks approved these changes Nov 14, 2025
View reviewed changes
Copy link
Member

@larsks larsks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we using Application resources?

@computate
Copy link
Member

computate commented Nov 14, 2025

Does this mean we are deploying an ArgoCD for prod that allows application deployment within a user's project?

@jtriley
Copy link
Contributor Author

jtriley commented Nov 17, 2025 •
edited
Loading

Where are we using Application resources?

I believe this is used as part of allowing users to deploy applications from templates out of their own github repos via the redhat oc-new-app github action:

https://github.com/redhat-actions/oc-new-app
https://nerc-project.github.io/nerc-docs/openshift/applications/creating-a-sample-application/
https://nerc-project.github.io/nerc-docs/other-tools/CI-CD/github-actions/setup-github-actions-pipeline/

@jtriley
Copy link
Contributor Author

jtriley commented Nov 17, 2025

Does this mean we are deploying an ArgoCD for prod that allows application deployment within a user's project?

No this is a different "application" crd in the app.k8s.io namespace vs argoproj.io/v1alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsks larsks larsks approved these changes

@tssala23 tssala23 tssala23 approved these changes

@schwesig schwesig schwesig approved these changes

@Milstein Milstein Awaiting requested review from Milstein

@computate computate Awaiting requested review from computate

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jtriley @computate @larsks @tssala23 @schwesig