Skip to content

Conversation

@renovate
Copy link

@renovate renovate bot commented Dec 1, 2025

This PR contains the following updates:

Package Change Age Confidence
express (source) 5.1.0 -> 5.2.0 age confidence

GitHub Vulnerability Alerts

CVE-2024-51999

Impact

when using the extended query parser in express ('query parser': 'extended'), the request.query object inherits all object prototype properties, but these properties can be overwritten by query string parameter keys that match the property names

Important

the extended query parser is the default in express 4; this was changed in express 5 which by default uses the simple query parser

Patches

the issue has been patched to ensure request.query is a plain object so request.query no longer has object prototype properties. this brings the default behavior of extended query parsing in line with express's default simple query parser

Workaround

this only impacts users using extended query parsing ('query parser': 'extended'), which is the default in express 4, but not express 5. all users are encouraged to upgrade to the patched versions, but can otherwise work around this issue:

provide qs directly and specify plainObjects: true

app.set('query parser',
  function (str) {
    return qs.parse(str, {
      plainObjects: true
  });
});

Release Notes

expressjs/express (express)

v5.2.0

Compare Source

========================

  • Security fix for CVE-2024-51999 (GHSA-pj86-cfqh-vqx6)
  • deps: body-parser@^2.2.1
  • A deprecation warning was added when using res.redirect with undefined arguments, Express now emits a warning to help detect calls that pass undefined as the status or URL and make them easier to fix.

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from commjoen as a code owner December 1, 2025 21:47
@renovate renovate bot added dependencies Pull requests that update a dependency file renovate labels Dec 1, 2025
@renovate renovate bot requested a review from bendehaan as a code owner December 1, 2025 21:47
@renovate renovate bot added dependencies Pull requests that update a dependency file renovate labels Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

🚀 Preview Deployment Ready!

Your pull request has been built and is ready for preview deployment.
Here's how to test your changes:

Container Images Built

  • Balancer: ghcr.io/OWASP/wrongsecrets-balancer:pr-1034
  • Cleaner: ghcr.io/OWASP/cleaner:pr-1034

Quick Deploy with Helm

# Add the wrongsecrets helm repository
helm repo add wrongsecrets https://owasp.org/wrongsecrets-ctf-party
helm repo update

# Deploy with preview images
helm install my-preview wrongsecrets/wrongsecrets-ctf-party \
  --set balancer.repository=ghcr.io/OWASP/wrongsecrets-balancer \
  --set balancer.tag=pr-1034 \
  --set wrongsecretsCleanup.repository=ghcr.io/OWASP/cleaner \
  --set wrongsecretsCleanup.tag=pr-1034 \
  --set imagePullPolicy=Always

# Port forward to access locally
kubectl port-forward service/wrongsecrets-balancer 3000:3000

Deploy with Custom Values

Click to see preview-values.yaml
balancer:
  repository: ghcr.io/OWASP/wrongsecrets-balancer
  tag: pr-1034

wrongsecretsCleanup:
  repository: ghcr.io/OWASP/cleaner
  tag: pr-1034

# Preview configuration
ingress:
  enabled: true
  hosts:
    - host: >-
        preview-pr-1034.wrongsecrets.local
      paths:
        - "/"
# Save the above values to preview-values.yaml, then:
helm install my-preview wrongsecrets/wrongsecrets-ctf-party \
  -f preview-values.yaml

Deploy with Local Build Scripts

# Clone this PR
git fetch origin pull/1034/head:pr-1034
git checkout pr-1034

# Use the existing deployment script with custom images
./build-and-deploy.sh

Test the Changes

  1. Access the application at http://localhost:3000
  2. Create a team and verify functionality
  3. Test any new features or bug fixes

Container Registry

The preview images are available at:


This preview was automatically generated for PR #1034

@commjoen commjoen merged commit 6e48132 into main Dec 2, 2025
18 checks passed
@commjoen commjoen deleted the renovate/npm-express-vulnerability branch December 2, 2025 08:52
@renovate renovate bot changed the title chore(deps): update dependency express to v5.2.0 [security] chore(deps): update dependency express to v5.2.0 [security] - autoclosed Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file renovate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants