-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat/schedule_PR] 피드백 적용 리팩터링 #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+906
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjdtjddns98
previously approved these changes
Dec 15, 2025
SWWS97
requested changes
Dec 15, 2025
7ea4787 to
1d62bf3
Compare
# apps/study_groups/urls.py # Conflicts: # apps/study_groups/tests/tests.py # apps/study_groups/urls.py # Conflicts: # apps/study_groups/urls.py
# ♻️ refactor : 리팩터링 : 각종 N+1 문제를 해결했습니다. 불필요한 코드를 제거했습니다.request.data로 data를 일괄 전달하게 바꾸었습니다. 중복되던 코드를 리팩토링했습니다. 유효성 검증 방식을 통일했습니다.
…했습니다. 변경사항에 맞는 결과 값을 검증하도록 test를 수정했습니다.
…응답이 처리되도록 수정하셨습니다.
063c66e to
1e9b775
Compare
SWWS97
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR 요약
📄 상세 내용