Skip to content

Commit 2f59487

Browse files
committed
🐛 fix(#58): api 명세에 맞춰 수정
1 parent 98ff653 commit 2f59487

File tree

2 files changed

+9
-25
lines changed

2 files changed

+9
-25
lines changed

apps/exams/services/admin/admin_deployment_service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import uuid
12
from datetime import datetime
23
from typing import Any, Dict, List, Optional, TypedDict
34

@@ -97,7 +98,6 @@ def create_deployment(
9798
cohort: Cohort,
9899
exam: Exam,
99100
duration_time: int,
100-
access_code: str,
101101
open_at: datetime,
102102
close_at: datetime,
103103
) -> ExamDeployment:
@@ -109,7 +109,7 @@ def create_deployment(
109109
cohort=cohort,
110110
exam=exam,
111111
duration_time=duration_time,
112-
access_code=access_code,
112+
access_code=str(uuid.uuid4())[:8],
113113
open_at=open_at,
114114
close_at=close_at,
115115
status=DeploymentStatus.ACTIVATED,

apps/exams/tests/admin/test_deployment_service.py

Lines changed: 7 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from datetime import datetime, timedelta
2-
from typing import Any, TypedDict
2+
from typing import Any
33

44
from django.test import TestCase
55
from django.utils import timezone
@@ -19,15 +19,6 @@
1919
)
2020

2121

22-
class CreateDeploymentParams(TypedDict):
23-
cohort: Cohort
24-
exam: Exam
25-
duration_time: int
26-
access_code: str
27-
open_at: datetime
28-
close_at: datetime
29-
30-
3122
class DeploymentServiceTests(TestCase):
3223

3324
# SETUP ---------------------------------------------------------
@@ -88,22 +79,16 @@ def _future_times() -> tuple[datetime, datetime]:
8879
return open_at, close_at
8980

9081
def _create_default_deployment(self, **override: Any) -> ExamDeployment:
91-
import uuid
9282

93-
base: CreateDeploymentParams = {
83+
base: dict[str, Any] = {
9484
"cohort": self.cohort,
9585
"exam": self.exam,
9686
"duration_time": 60,
97-
# "access_code": "000",
98-
"access_code": str(uuid.uuid4())[:8],
9987
"open_at": self.open_at,
10088
"close_at": self.close_at,
10189
}
10290

103-
params: CreateDeploymentParams = {
104-
**base,
105-
**override, # type: ignore[typeddict-item]
106-
}
91+
params = {**base, **override}
10792

10893
return create_deployment(**params)
10994

@@ -130,7 +115,7 @@ def test_create_deployment_fail_open_at_past(self) -> None:
130115
self._create_default_deployment(open_at=timezone.now() - timedelta(hours=1))
131116

132117
def test_create_deployment_fail_course_mismatch(self) -> None:
133-
other_course = Course.objects.create(name="공주의 스타일기")
118+
# other_course = Course.objects.create(name="공주의 스타일기")
134119
other_cohort = Cohort.objects.create(
135120
course=self.course,
136121
number=2,
@@ -213,9 +198,8 @@ def test_delete_deployment_fail_already_started(self) -> None:
213198
# LIST ---------------------------------------------------------
214199

215200
def test_list_deployments_default(self) -> None:
216-
d1 = self._create_default_deployment(access_code="111")
201+
d1 = self._create_default_deployment()
217202
d2 = self._create_default_deployment(
218-
access_code="222",
219203
open_at=self.open_at + timedelta(hours=1),
220204
close_at=self.close_at + timedelta(hours=1),
221205
)
@@ -253,8 +237,8 @@ def test_list_deployments_filter_by_cohort(self) -> None:
253237
self.assertEqual(first.id, d1.id)
254238

255239
def test_list_deployments_filter_by_status(self) -> None:
256-
d1 = self._create_default_deployment(access_code="111")
257-
self._create_default_deployment(access_code="222")
240+
d1 = self._create_default_deployment()
241+
self._create_default_deployment()
258242

259243
set_deployment_status(
260244
deployment=d1,

0 commit comments

Comments
 (0)