Fix IPv6 validation #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks so much for the PR. I'll have a look as soon as I get a chance, and I will try my hardest not to forget about this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updated the regex used to validate that a string is a valid IPv6 CIDR. The complex regex here was NOT developed by me, from scratch, but taken from the widely used "cidr-regex" npm package.
Given its widespread use, and that it successfully categorized all tests I threw at it (Which consisted of the list of reserved IPv6 ranges on this wikipedia page: https://en.wikipedia.org/wiki/Reserved_IP_addresses), I believe it is correct.
Resolves #6