Add support for multiple result node #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
todo
|
soxofaan
commented
Nov 5, 2024
soxofaan
commented
Nov 5, 2024
soxofaan
added a commit
that referenced
this pull request
Nov 5, 2024
soxofaan
added a commit
that referenced
this pull request
Nov 5, 2024
soxofaan
commented
Nov 5, 2024
soxofaan
added a commit
that referenced
this pull request
Nov 5, 2024
soxofaan
added a commit
that referenced
this pull request
Nov 5, 2024
Make GraphFlattener multi-input-sensitive, and be more careful about accidental mutation in this context
soxofaan
force-pushed
the
issue391-multiple-result-nodes
branch
from
b2edbff to
334b819
Compare
Member
Author
|
I think this is ready to merge, but still a quick review could be handy to make sure there is no mismatch in expectations. @jdries @HansVRP @VincentVerelst This is quite a large PR in terms of lines of code, but the essential tl;dr is basically described at https://github.com/Open-EO/openeo-python-client/pull/651/files#diff-28f4328e7d44f5afd6d4a6ce10ed344de812d2f2d9460a913c8e65e0a77cdeb5 |
jdries
approved these changes
Nov 6, 2024
Collaborator
|
approved, one general comment about imports: for our public API, I would prefer to import like: |
Member
Author
good point, added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #391