Skip to content

job manager tests: fail on any warning #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −0
Draft

job manager tests: fail on any warning #662

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f98b3d3
job manager tests: fail on all warnings (except our own deprecation w…
soxofaan Nov 14, 2024
3945341
PR #662 set filterwarnings globally on test_job_management
soxofaan Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/extra/test_job_management.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ def sleep_mock():
yield sleep


@pytest.mark.filterwarnings("default:.*`output_file` argument is deprecated.*:DeprecationWarning")
@pytest.mark.filterwarnings("error")
Copy link
Member Author

@soxofaan soxofaan Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it is also possible to set these markers at module level, (instead of only on this test class), with the pytestmark module global var according to https://docs.pytest.org/en/stable/how-to/capture-warnings.html#pytest-mark-filterwarnings

class TestMultiBackendJobManager:

@pytest.fixture
Expand Down
Loading