Fix: Prevent Admin from demoting their own role (#9326) #9389
+14
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses Issue #9326.
I implemented a validation check in
user_service.py(inside theupdatemethod) to prevent an Admin user from demoting their own role permissions. This fixes a logic gap where an admin could accidentally lock themselves out of administrative privileges.Specifically:
uidmatchescontext.credentials(the user modifying themselves).ADMIN.SyftErrorwith the message "Admins cannot demote their own role!" if a demotion is attempted.Fixes #9326
Affected Dependencies
None. This change only modifies internal logic in
packages/syft/src/syft/service/user/user_service.py.How has this been tested?
user_service.pyto ensure the conditional logic correctly targets only self-updates by Admin users.Checklist