railway_manager_interface: fix shebang of generate-types script #14301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Dec 5, 2025
flomonster
force-pushed
the
fam/fix-shebang
branch
from
d225c99 to
94b9d7d
Compare
emersion
previously approved these changes
Dec 5, 2025
Member
emersion
left a comment
emersion
left a comment
There was a problem hiding this comment.
#!/bin/sh is usually more portable than #!/usr/bin/env sh, but either way this patch LGTM.
Member
|
CI fails with this warning: However, POSIX.1-2024 specifies |
Signed-off-by: Florian Amsallem <[email protected]>
flomonster
force-pushed
the
fam/fix-shebang
branch
from
94b9d7d to
5b5522d
Compare
Khoyo
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/bin/env bashis more reliable and portable across different systems.