-
Notifications
You must be signed in to change notification settings - Fork 186
docs: LLD and liquid classes #19806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: LLD and liquid classes #19806
Conversation
jwwojak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ye olde HTML suggestion included, free!
ecormany
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LLD additions are good. The Introduction refactor needs some additional work, which you can either do here or move to a separate PR, since it's not focused on the LLD feature.
jwwojak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, LGTM.
Still think you should use suspended hyphens though. 😜
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## edge #19806 +/- ##
==========================================
+ Coverage 24.23% 25.48% +1.25%
==========================================
Files 3540 3540
Lines 298345 298348 +3
Branches 39863 39863
==========================================
+ Hits 72298 76048 +3750
+ Misses 226029 222276 -3753
- Partials 18 24 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
c744bc6 to
f17a34f
Compare
f6505c3 to
e4bf7d9
Compare
ecormany
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good additions. We will surely have more to say about LLD in the future, but let's get this committed for now.
<!-- Thanks for taking the time to open a Pull Request (PR)! Please make sure you've read the "Opening Pull Requests" section of our Contributing Guide: https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests GitHub provides robust markdown to format your PR. Links, diagrams, pictures, and videos along with text formatting make it possible to create a rich and informative PR. For more information on GitHub markdown, see: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax To ensure your code is reviewed quickly and thoroughly, please fill out the sections below to the best of your ability! --> # Overview reworking the "what's new on Flex" section > "Flex-exclusive features" for a few reasons: - the OT-2 and Flex comparison is no longer what's most important in the introduction. here, I've walked back the comparison text (but still include a small section to do so). - this section can be useful to us to describe what's different/exclusive to Flex without comparison. This can also be a soft landing place for new features that aren't ready for an entire section, but will be one day (like LLD. After 8.8, this could very well get its own section). -also sprinkling throughout: LLD, liquid classes, a mention of liquid classes in QT. Trying to bridge the gap before some of these features get more new shiny things added to them and can have their own section (LLD mostly). <!-- Describe your PR at a high level. State acceptance criteria and how this PR fits into other work. Link issues, PRs, and other relevant resources. --> ## Test Plan and Hands on Testing <!-- Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing. --> ## Changelog <!-- List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes. --> ## Review requests <!-- - What do you need from reviewers to feel confident this PR is ready to merge? - Ask questions. --> ## Risk assessment <!-- - Indicate the level of attention this PR needs. - Provide context to guide reviewers. - Discuss trade-offs, coupling, and side effects. - Look for the possibility, even if you think it's small, that your change may affect some other part of the system. - For instance, changing return tip behavior may also change the behavior of labware calibration. - How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions? - Especially in high risk PRs, explain how you know your testing is enough. -->
<!-- Thanks for taking the time to open a Pull Request (PR)! Please make sure you've read the "Opening Pull Requests" section of our Contributing Guide: https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests GitHub provides robust markdown to format your PR. Links, diagrams, pictures, and videos along with text formatting make it possible to create a rich and informative PR. For more information on GitHub markdown, see: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax To ensure your code is reviewed quickly and thoroughly, please fill out the sections below to the best of your ability! --> # Overview reworking the "what's new on Flex" section > "Flex-exclusive features" for a few reasons: - the OT-2 and Flex comparison is no longer what's most important in the introduction. here, I've walked back the comparison text (but still include a small section to do so). - this section can be useful to us to describe what's different/exclusive to Flex without comparison. This can also be a soft landing place for new features that aren't ready for an entire section, but will be one day (like LLD. After 8.8, this could very well get its own section). -also sprinkling throughout: LLD, liquid classes, a mention of liquid classes in QT. Trying to bridge the gap before some of these features get more new shiny things added to them and can have their own section (LLD mostly). <!-- Describe your PR at a high level. State acceptance criteria and how this PR fits into other work. Link issues, PRs, and other relevant resources. --> ## Test Plan and Hands on Testing <!-- Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing. --> ## Changelog <!-- List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes. --> ## Review requests <!-- - What do you need from reviewers to feel confident this PR is ready to merge? - Ask questions. --> ## Risk assessment <!-- - Indicate the level of attention this PR needs. - Provide context to guide reviewers. - Discuss trade-offs, coupling, and side effects. - Look for the possibility, even if you think it's small, that your change may affect some other part of the system. - For instance, changing return tip behavior may also change the behavior of labware calibration. - How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions? - Especially in high risk PRs, explain how you know your testing is enough. -->
Overview
reworking the "what's new on Flex" section > "Flex-exclusive features" for a few reasons:
-also sprinkling throughout: LLD, liquid classes, a mention of liquid classes in QT. Trying to bridge the gap before some of these features get more new shiny things added to them and can have their own section (LLD mostly).
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment