-
Notifications
You must be signed in to change notification settings - Fork 186
feat(pd, step-generation): wire up Python step generation for select tip #19952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR wires up select tip args in transfer, consolidate, and distribute compound command creators. Closes AUTH-2432
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #19952 +/- ##
==========================================
- Coverage 25.20% 24.67% -0.54%
==========================================
Files 3528 3555 +27
Lines 294549 299644 +5095
Branches 39559 39987 +428
==========================================
- Hits 74240 73930 -310
- Misses 220286 225695 +5409
+ Partials 23 19 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
koji
reviewed
Oct 29, 2025
koji
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR wires up select tip args in transfer, consolidate, and distribute compound command creators.
Closes AUTH-2432
Test Plan and Hands on Testing
Wrote extensive unit tests here to check the logic of each combination of nozzle configuration, pipette channels, and primary nozzles for determining which tips to target given a nested list of tips and the aforementioned factors.
In practice:
[transfer/consolidate/distribute]_with_liquid_classsteptipsargument is included, targeting selected wellsChangelog
tipsin transfer, consolidate, and distribute compound command creatorsReview requests
not much beyond inspecting code and tests. see test plan
Risk assessment
lowish. should only impact manual tip selection