Skip to content

Conversation

@ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Oct 28, 2025

Overview

This PR wires up select tip args in transfer, consolidate, and distribute compound command creators.

Closes AUTH-2432

Test Plan and Hands on Testing

Wrote extensive unit tests here to check the logic of each combination of nozzle configuration, pipette channels, and primary nozzles for determining which tips to target given a nested list of tips and the aforementioned factors.

In practice:

  • create a moveLiquid step with manual tip selection
  • export the Python and inspect the emitted [transfer/consolidate/distribute]_with_liquid_class step
  • verify that the tips argument is included, targeting selected wells

Changelog

  • implement Python arg for tips in transfer, consolidate, and distribute compound command creators
  • add utility for determining which tips to target given pipette configuration and selected tip lists
  • fix up args types and tests

Review requests

not much beyond inspecting code and tests. see test plan

Risk assessment

lowish. should only impact manual tip selection

ncdiehl11 and others added 2 commits October 28, 2025 14:24
This PR wires up select tip args in transfer, consolidate, and distribute compound command creators.

Closes AUTH-2432
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 97.56098% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.67%. Comparing base (9faa319) to head (a827ab7).
⚠️ Report is 2 commits behind head on edge.

Files with missing lines Patch % Lines
...ickTransferFlow/utils/generateQuickTransferArgs.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #19952      +/-   ##
==========================================
- Coverage   25.20%   24.67%   -0.54%     
==========================================
  Files        3528     3555      +27     
  Lines      294549   299644    +5095     
  Branches    39559    39987     +428     
==========================================
- Hits        74240    73930     -310     
- Misses     220286   225695    +5409     
+ Partials       23       19       -4     
Flag Coverage Δ
protocol-designer 18.77% <41.46%> (+<0.01%) ⬆️
step-generation 5.47% <87.80%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol-designer/src/form-types.ts 60.97% <ø> (-10.46%) ⬇️
...steplist/formLevel/stepFormToArgs/mixFormToArgs.ts 93.10% <100.00%> (ø)
...t/formLevel/stepFormToArgs/moveLiquidFormToArgs.ts 72.78% <100.00%> (-2.44%) ⬇️
...ormLevel/stepFormToArgs/test/mixFormToArgs.test.ts 88.83% <100.00%> (ø)
...l/stepFormToArgs/test/moveLiquidFormToArgs.test.ts 86.79% <100.00%> (-1.67%) ⬇️
...ration/src/commandCreators/compound/consolidate.ts 77.07% <100.00%> (-1.13%) ⬇️
...eration/src/commandCreators/compound/distribute.ts 73.71% <100.00%> (-1.80%) ⬇️
...eneration/src/commandCreators/compound/transfer.ts 83.67% <100.00%> (-1.21%) ⬇️
step-generation/src/types.ts 100.00% <ø> (ø)
step-generation/src/utils/safePipetteMovements.ts 85.04% <100.00%> (-0.43%) ⬇️
... and 1 more

... and 314 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ncdiehl11 ncdiehl11 changed the title feat(pd,-step-generation): wire up Python step generation for select tip feat(pd step-generation): wire up Python step generation for select tip Oct 28, 2025
@ncdiehl11 ncdiehl11 changed the title feat(pd step-generation): wire up Python step generation for select tip feat(pd, step-generation): wire up Python step generation for select tip Oct 28, 2025
@ncdiehl11 ncdiehl11 requested a review from koji October 28, 2025 20:06
@ncdiehl11 ncdiehl11 self-assigned this Oct 28, 2025
@ncdiehl11 ncdiehl11 marked this pull request as ready for review October 28, 2025 20:11
@koji koji self-requested a review October 29, 2025 14:30
@ncdiehl11 ncdiehl11 merged commit 51dc410 into edge Oct 30, 2025
46 of 47 checks passed
@ncdiehl11 ncdiehl11 deleted the sg_feat-wireup-python-selecttip branch October 30, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants