Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public override IDisplayResult Edit(IndexProfile indexProfile, BuildEditorContex
model.IndexLatest = metadata.IndexLatest;
model.IndexedContentTypes = metadata.IndexedContentTypes;
model.Culture = metadata.Culture;
model.Cultures = ILocalizationService.GetAllCulturesAndAliases()
model.Cultures = CultureInfoWrapper.GetCultures()
.Select(culture => new SelectListItem
{
Text = $"{culture.Name} ({culture.DisplayName})",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\OrchardCore\OrchardCore\OrchardCore.csproj" />
<ProjectReference Include="..\..\OrchardCore\OrchardCore.Admin.Abstractions\OrchardCore.Admin.Abstractions.csproj" />
<ProjectReference Include="..\..\OrchardCore\OrchardCore.ContentPreview.Abstractions\OrchardCore.ContentPreview.Abstractions.csproj" />
<ProjectReference Include="..\..\OrchardCore\OrchardCore.ContentTypes.Abstractions\OrchardCore.ContentTypes.Abstractions.csproj" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public override async Task<IDisplayResult> EditAsync(ISite site, LocalizationSet

return Initialize<LocalizationSettingsViewModel>("LocalizationSettings_Edit", model =>
{
model.Cultures = ILocalizationService.GetAllCulturesAndAliases()
model.Cultures = CultureInfoWrapper.GetCultures()
.Select(cultureInfo =>
{
return new CultureEntry
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\OrchardCore\OrchardCore\OrchardCore.csproj" />
<ProjectReference Include="..\..\OrchardCore\OrchardCore.Admin.Abstractions\OrchardCore.Admin.Abstractions.csproj" />
<ProjectReference Include="..\..\OrchardCore\OrchardCore.Apis.GraphQL.Abstractions\OrchardCore.Apis.GraphQL.Abstractions.csproj" />
<ProjectReference Include="..\..\OrchardCore\OrchardCore.ContentManagement.GraphQL\OrchardCore.ContentManagement.GraphQL.csproj" />
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
using System.Globalization;

namespace OrchardCore.Localization;

public interface ICultureAliasProvider
{
IEnumerable<CultureInfo> GetCultureAliases();
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@ public interface ILocalizationService
/// </summary>
bool FallBackToParentCultures { get; }

/// <summary>
/// Gets all cultures recognized by .NET, including culture aliases.
/// </summary>
[Obsolete("This method is deprecated and will be removed in a future version. Use CultureInfoWrapper.GetAllCulturesAndAliases() instead.")]
static CultureInfo[] GetAllCulturesAndAliases()
{
var cultures = CultureInfo.GetCultures(CultureTypes.AllCultures)
Expand Down
27 changes: 27 additions & 0 deletions src/OrchardCore/OrchardCore/Localization/CultureInfoWrapper.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
using System.Globalization;
using Microsoft.Extensions.DependencyInjection;
using OrchardCore.Environment.Shell.Scope;

namespace OrchardCore.Localization;

public static class CultureInfoWrapper
{
/// <summary>
/// Gets all cultures recognized by .NET, including culture aliases.
/// </summary>
public static CultureInfo[] GetCultures()
{
var cultureAliasProviders = ShellScope.Current.ServiceProvider.GetServices<ICultureAliasProvider>();

var cultures = CultureInfo.GetCultures(CultureTypes.AllCultures).AsEnumerable();

if (cultureAliasProviders.Any())
{
cultures = cultures.Union(cultureAliasProviders.SelectMany(provider => provider.GetCultureAliases()));
}

return cultures
.OrderBy(c => c.Name)
.ToArray();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
using System.Globalization;

namespace OrchardCore.Localization;

public sealed class DefaultCultureAliasProvider : ICultureAliasProvider
{
private static readonly CultureInfo[] _cultureAliases =
[
CultureInfo.GetCultureInfo("zh-CN"),
CultureInfo.GetCultureInfo("zh-TW")
];

public IEnumerable<CultureInfo> GetCultureAliases() => _cultureAliases;
}
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ private static void AddDefaultServices(OrchardCoreBuilder builder)
services.AddScoped<ILocalizationService, DefaultLocalizationService>();
services.AddScoped<ICalendarManager, DefaultCalendarManager>();
services.AddScoped<ICalendarSelector, DefaultCalendarSelector>();
services.AddScoped<ICultureAliasProvider, DefaultCultureAliasProvider>();

services.AddSingleton<IPoweredByMiddlewareOptions, PoweredByMiddlewareOptions>();
services.AddTransient<IConfigureOptions<DocumentJsonSerializerOptions>, DocumentJsonSerializerOptionsConfiguration>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,16 @@

namespace OrchardCore.Tests.Localization;

public class LocalizationService
public class DefaultCultureAliasProviderTests
{
[Fact]
public void GetAllCulturesAndAliases_ShouldContainsChineseCultures()
{
// Arrange
var provider = new DefaultCultureAliasProvider();

// Act
var cultures = ILocalizationService.GetAllCulturesAndAliases();
var cultures = provider.GetCultureAliases();

// Assert
Assert.Single(cultures, c => c.Name == "zh-CN");
Expand Down