Skip to content

Replace Irony-based SqlParser with Parlot SqlParser #18503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastienros merged 25 commits into from
Nov 26, 2025
+1,844 −1,134
Merged

Replace Irony-based SqlParser with Parlot SqlParser #18503

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
42ab9fd
Initial plan
Copilot Oct 27, 2025
95033e8
Add Parlot package and initial SqlAst, SqlParser, SqlTranslator struc…
Copilot Oct 27, 2025
77163d7
Add working ParlotSqlParser with 74/98 tests passing
Copilot Oct 27, 2025
012f595
Improve parameter parser priority (still 74/98 tests passing)
Copilot Oct 27, 2025
6d1fb64
Update Parlot to version 1.5.1
Copilot Oct 27, 2025
5d729b9
Revert ZeroOrOne to Optional API (Parlot 1.5.1)
Copilot Oct 27, 2025
be7c96f
Cleanup grammar
sebastienros Oct 30, 2025
6b0395e
Add trailing comma
hishamco Oct 30, 2025
02b7eb4
Add static when it's possible
hishamco Oct 30, 2025
62ec7fd
Update Parlot 1.5.2
hishamco Nov 3, 2025
67e466e
Fix unit tests
sebastienros Nov 15, 2025
513529b
Merge branch 'main' into copilot/replace-sqlparser-with-parlot
sebastienros Nov 15, 2025
228efdd
Nits
sebastienros Nov 15, 2025
63f640b
Use new WhiteSpace parser
sebastienros Nov 22, 2025
8fbd1a4
Perf improvements
sebastienros Nov 22, 2025
671ce54
Formatting
Piedone Nov 23, 2025
553f94c
Fix NRE when error is null and add ORDER BY LIMIT tests
Copilot Nov 23, 2025
f9c7dd2
Fix OneOrMany regression and document WHERE+ORDER BY parsing issue
Copilot Nov 23, 2025
6b298a6
Merge main branch and resolve conflicts - update to .NET 10.0
Copilot Nov 23, 2025
4c3d7cd
Merge remote-tracking branch 'origin/main' into copilot/replace-sqlpa…
Piedone Nov 23, 2025
52f342d
Add tests for WHERE + ORDER BY parsing issue
Copilot Nov 23, 2025
e509319
Use Keyword parser to prevent OR/ORDER conflict
sebastienros Nov 24, 2025
80558ca
Remove leftover backup files
Piedone Nov 24, 2025
da81c7f
Improve performance and allocations
sebastienros Nov 25, 2025
46f1e73
Merge branch 'main' into copilot/replace-sqlparser-with-parlot
sebastienros Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
<PackageVersion Include="Jint" Version="4.4.1" />
<PackageVersion Include="JsonPath.Net" Version="2.1.1" />
<PackageVersion Include="HtmlSanitizer" Version="9.1.878-beta" />
<PackageVersion Include="Parlot" Version="1.5.2" />
<PackageVersion Include="Irony" Version="1.5.3" />
<PackageVersion Include="libphonenumber-csharp" Version="9.0.18" />
<PackageVersion Include="Lorem.Universal.NET" Version="5.0.0" />
Expand Down
2 changes: 1 addition & 1 deletion src/OrchardCore.Modules/OrchardCore.Queries/OrchardCore.Queries.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Irony" />
<PackageReference Include="Parlot" />
</ItemGroup>

</Project>
439 changes: 439 additions & 0 deletions src/OrchardCore.Modules/OrchardCore.Queries/Sql/ParlotSqlParser.cs
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading