Add v2.Problem.has_{map,ml}_objective
#463
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
+ Coverage 75.18% 75.21% +0.02%
==========================================
Files 62 62
Lines 6856 6862 +6
Branches 1224 1224
==========================================
+ Hits 5155 5161 +6
Misses 1234 1234
Partials 467 467 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
To check for the type of objective function encoded in the PEtab problem.
dilpath
approved these changes
Dec 4, 2025
Comment on lines
+1842
to
+1843
| Note that this will default to uniform distributions over the | ||
| parameter bounds for parameters without an explicit prior. |
Member
There was a problem hiding this comment.
Add this to avoid invalid behavior? if self.has_ml_objective: return None
Comment on lines
+1835
to
+1837
| return all( | ||
| p.prior_distribution is None for p in self.parameters if p.estimate | ||
| ) |
Member
There was a problem hiding this comment.
Since it's binary
Suggested change
| return all( | |
| p.prior_distribution is None for p in self.parameters if p.estimate | |
| ) | |
| return not self.has_map_objective |
| :returns: The prior distributions for the estimated parameters. | ||
| """ | ||
| return {p.id: p.prior_dist for p in self.parameters if p.estimate} |
Member
There was a problem hiding this comment.
Unrelated but Parameter.prior_dist seems confusing since it can differ from Parameter.prior_distribution. It seems like this default to the uniform distribution should be handled by Problem-level methods, rather than within the Parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check for the type of objective function encoded in the PEtab problem.