Skip to content

refactor init_MAN3PODS so pod files get priority #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor init_MAN3PODS so pod files get priority #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 31 additions & 33 deletions lib/ExtUtils/MM_Unix.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1575,43 +1575,41 @@ Initializes MAN3PODS from the list of PM files.
sub init_MAN3PODS {
my $self = shift;

my %manifypods = (); # we collect the keys first, i.e. the files
# we have to convert to pod

foreach my $name (keys %{$self->{PM}}) {
if ($name =~ /\.pod\z/ ) {
$manifypods{$name} = $self->{PM}{$name};
} elsif ($name =~ /\.p[ml]\z/ ) {
if( $self->_has_pod($name) ) {
$manifypods{$name} = $self->{PM}{$name};
}
}
}

my $parentlibs_re = join '|', @{$self->{PMLIBPARENTDIRS}};

# Remove "Configure.pm" and similar, if it's not the only pod listed
# To force inclusion, just name it "Configure.pod", or override
# MAN3PODS
foreach my $name (keys %manifypods) {
if (
my %man;
foreach my $name (sort keys %{$self->{PM}}) {
# Remove "Configure.pm" and similar, if it's not the only pod listed
# To force inclusion, just name it "Configure.pod", or override
# MAN3PODS
if (
($self->{PERL_CORE} and $name =~ /(config|setup).*\.pm/is) or
( $name =~ m/^README\.pod$/i ) # don't manify top-level README.pod
) {
delete $manifypods{$name};
next;
}
my($manpagename) = $name;
$manpagename =~ s/\.p(od|m|l)\z//;
# everything below lib is ok
unless($manpagename =~ s!^\W*($parentlibs_re)\W+!!s) {
$manpagename = $self->catfile(
split(/::/,$self->{PARENT_NAME}),$manpagename
);
}
$manpagename = $self->replace_manpage_separator($manpagename);
$self->{MAN3PODS}->{$name} =
$self->catfile("\$(INST_MAN3DIR)", "$manpagename.\$(MAN3EXT)");
next;
}
my $man = $name;
$man =~ s/\.(p(?:od|m|l))\z//;
my $ext = $1;
unless ($man =~ s!^\W*($parentlibs_re)\W+!!s) {
$man = $self->catfile(
split(/::/,$self->{PARENT_NAME}),$man
);
}
$man = $self->replace_manpage_separator($man) .'.$(MAN3EXT)';
if ($ext && $ext eq 'pod') {
$man{$man} = $name;
}
else {
$man{$man} ||= $name;
}
}

foreach my $man (keys %man) {
my $name = $man{$man};
next
if $name =~ /\.p[ml]\z/ && !$self->_has_pod($name);
$self->{MAN3PODS}->{$name} =
$self->catfile("\$(INST_MAN3DIR)", $man);
}
}

Expand Down