Respect TrustRepository parameter in RequiredResource hashtable #1910
+76
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: adityapatwardhan <[email protected]>
…ests Co-authored-by: adityapatwardhan <[email protected]>
Co-authored-by: adityapatwardhan <[email protected]>
Co-authored-by: adityapatwardhan <[email protected]>
Copilot
AI
changed the title
[WIP] Fix TrustRepository handling in RequiredResource
Respect TrustRepository parameter in RequiredResource hashtable
Nov 19, 2025
Copilot finished work on behalf of
adityapatwardhan
November 19, 2025 19:43
adityapatwardhan
approved these changes
Nov 19, 2025
adityapatwardhan
requested review from
SydneyhSmith,
alerickson,
anamnavi and
shammu1
as code owners
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
shammu1
approved these changes
Nov 19, 2025
alerickson
approved these changes
Nov 20, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@copilot "bool acceptLicense = reqResourceParams != null ? reqResourceParams.AcceptLicense : AcceptLicense; |
…alse This addresses the feedback to check if reqResourceParams properties are null. Now the code can distinguish between: - User didn't specify the property (null) -> use cmdlet-level parameter - User explicitly set the property to true/false -> use that value Changed properties to nullable (bool?, ScopeType?) and updated logic to only set them when explicitly provided in the RequiredResource hashtable. Co-authored-by: alerickson <[email protected]>
Contributor
Author
Updated to use nullable properties ( Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
alerickson
November 20, 2025 20:40
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alerickson
approved these changes
Nov 20, 2025
shammu1
approved these changes
Nov 20, 2025
adityapatwardhan
approved these changes
Nov 21, 2025
anamnavi
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan to Fix TrustRepository in RequiredResource
Summary
This PR successfully fixes the issue where
TrustRepositoryparameter specified in the-RequiredResourcehashtable was not being respected.Root Cause
The
ProcessInstallHelpermethod inInstallPSResource.cswas always using cmdlet-level parameters (likeTrustRepository,AcceptLicense, etc.) when callingBeginInstallPackages, even whenreqResourceParamswas provided via-RequiredResource. Additionally, boolean properties couldn't distinguish between "not set" and "set to false".Solution
InstallPkgParamsnullable (bool?,ScopeType?)ProcessInstallHelperto use null-coalescing operator (??) to prefer RequiredResource values when set, otherwise fall back to cmdlet-level parametersChanges Made
InstallPkgParams.cs:
InstallPSResource.cs:
Test Coverage: Added tests for both V2 and V3 server scenarios to verify TrustRepository in RequiredResource
Review Feedback Addressed
Security
Testing
Tests verify that when TrustRepository is specified in the RequiredResource hashtable, the module installs without prompting for confirmation.
Original prompt
-RequiredResourceshould be respected #1900💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.