clarify that prefect server services ls shows configuration, not runtime state
#19160
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntime state this addresses confusion when users run `prefect server start --no-services` and then check `prefect server services ls`, which still shows services as "enabled" even though they're not running. changes: - column header: "Enabled?" → "Configured?" - help text: clarified this shows environment variable configuration - footer note: explicitly states services won't run with --no-services or --workers > 1 fixes the misleading output reported in slack by ryan sharp 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
CodSpeed Performance ReportMerging #19160 will not alter performanceComparing Summary
|
desertaxle
reviewed
Oct 14, 2025
| table = Table(title="Available Services", expand=True) | ||
| table.add_column("Name", no_wrap=True) | ||
| table.add_column("Enabled?", no_wrap=True) | ||
| table.add_column("Configured?", no_wrap=True) |
There was a problem hiding this comment.
I prefer Enabled? over Configured?. I think that the message below clearly communicates the information that's being displayed and Enabled? makes more sense.
Suggested change
| table.add_column("Configured?", no_wrap=True) | |
| table.add_column("Enabled?", no_wrap=True) |
Comment on lines
+749
to
+751
| "\n[dim]Note: This shows configuration via environment variables. " | ||
| "Services will not run if the server\n" | ||
| " was started with --no-services or --workers > 1.[/dim]" |
There was a problem hiding this comment.
Suggested change
| "\n[dim]Note: This shows configuration via environment variables. " | |
| "Services will not run if the server\n" | |
| " was started with --no-services or --workers > 1.[/dim]" | |
| "\n[dim]Note: This shows services enabled via the current settings, not running status." | |
| "Services will not run if the server\n" | |
| " was started with --no-services or --workers > 1.[/dim]" |
| """ | ||
| List all available services and their configuration status. | ||
| This shows which services are configured to be enabled via environment variables. |
There was a problem hiding this comment.
Suggested change
| This shows which services are configured to be enabled via environment variables. | |
| This shows which services are configured to be enabled via the current settings. |
|
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context
when users run
prefect server start --no-servicesand then checkprefect server services ls, the output shows services as "enabled" even though they're not actually running. this is confusing.the issue is that
services lsshows which services are configured to be enabled via environment variables, not which services are actually running.reported by a user in slack - he was seeing all services listed as enabled even with
--no-services.changes
--no-servicesor--workers > 1before
after
related
🤖 Generated with Claude Code