- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2k
          Remove deprecated code Runner functionality and system Blocks
          #19307
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR removes all deprecated code from core Prefect that has reached or passed its scheduled removal date: **Removed Blocks:** - JSON, String, DateTime blocks (deprecated June 2024, removal date June 2025) **Removed Functions:** - ResultStore.store_parameters() and read_parameters() (deprecated May 2025, removal date November 2025) - build_server() and start_webserver() from runner.server (deprecated April 2025, removal date October 2025) - submit_to_runner() and wait_for_submitted_runs() from runner.submit (deprecated April 2025, removal date October 2025) - DeploymentClient.set_deployment_paused_state() sync and async (deprecated June 2025, removal date December 2025) **Removed CLI Commands:** - `prefect cloud open` (deprecated October 2024, removal date April 2025) **Updates:** - Updated server block registration to remove deprecated blocks - Removed tests for deprecated functionality - Cleaned up imports and exports Pydantic schema fields and integration-specific deprecations were kept as requested. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
| CodSpeed Performance ReportMerging #19307 will not alter performanceComparing  Summary
 | 
- Remove webserver parameter from Runner.__init__() and Runner.start() - Remove unused _build_generic_endpoint_for_flows and related helper functions - Update test_block_registration.py to remove json and date-time blocks - Clean up unused imports Fixes type check errors and server test failures.
Runner functionality and system Blocks
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woohoo!!
| pytest-timeout \ | ||
| pytest-env | ||
| pytest --ignore=integration-tests/test_task_worker.py --ignore=integration-tests/test_concurrency_leases.py integration-tests/ -n auto -vv | ||
| pytest --ignore=integration-tests/test_task_worker.py --ignore=integration-tests/test_concurrency_leases.py --ignore=integration-tests/test_deploy.py integration-tests/ -n auto -vv | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we adding this ignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test requires the flow-run execute CLI, which isn't available in prefect-client. I'm not quite sure how it was passing before, but pulling a flow from a different repo for the test caused issues.
Summary
This PR removes all deprecated code from core Prefect that has reached or passed its scheduled removal date.
Changes
Removed Blocks
src/prefect/blocks/system.pyRemoved Functions
ResultStore.store_parameters() and read_parameters() (deprecated May 2025, removal date November 2025)
prefect.task_workermodulebuild_server() and start_webserver() from runner.server (deprecated April 2025, removal date October 2025)
.serve()methodsubmit_to_runner() and wait_for_submitted_runs() from runner.submit (deprecated April 2025, removal date October 2025)
run_deployment()DeploymentClient.set_deployment_paused_state() sync and async (deprecated June 2025, removal date December 2025)
pause_deployment()andresume_deployment()methodsRemoved CLI Commands
prefect cloud open(deprecated October 2024, removal date April 2025)prefect dashboard openOther Updates
Impact
🤖 Generated with Claude Code