Resa classe Player un singleton e piccole modifiche

src/dungeon/Graphic.java

@@ -0,0 +1,5 @@
+package dungeon;
+
+public class Graphic {
+    // work in progress
+}

src/dungeon/ItemCollection.java

@@ -5,7 +5,7 @@
 
 public class ItemCollection {
 
-    private Vector<Item> contenuto;
+    private final Vector<Item> contenuto;
 
     public ItemCollection(Vector<Item> contenuto) {
         this.contenuto = contenuto;
@@ -19,14 +19,14 @@ public void addItem(Item item){
         contenuto.add(item);
     }
 
-    public int elementi(){
+    public int elementi() {
         return contenuto.size();
     }
 
     public String elementiContenuti(){
         var sg = new StringJoiner(",");
-        for(int i = 0; i < contenuto.size(); i++){
-            sg.add(contenuto.get(i).getNome());
+        for (Item item : contenuto) {
+            sg.add(item.getNome());
         }
         return sg.toString();
     }

src/dungeon/App.java → src/dungeon/MainGame.java

@@ -3,11 +3,8 @@
 import processing.core.PApplet;
 import processing.event.KeyEvent;
 
-public class App extends PApplet {
-
-    private Player player;
-
-    public App() {
+public class MainGame extends PApplet {
+    public MainGame() {
 
     }
 
@@ -18,8 +15,8 @@ public void settings() {
 
     @Override
     public void setup() {
-        player = new Player("Hero",getGraphics());
-        player.setPos(10,10);
+        Player.getPlayerInstance("Giovanni", getGraphics());
+        Player.setPos(10,10);
 
     }
 
@@ -28,18 +25,18 @@ public void draw() {
         background(55);
         update();
 
-        player.draw();
+        Player.draw();
     }
 
 
 
     @Override
     public void keyPressed(KeyEvent event) {
         switch (event.getKeyCode()) {
-            case 65 -> player.move(-1, 0);
-            case 68 -> player.move(1, 0);
-            case 87 -> player.move(0,-1);
-            case 83 -> player.move(0,1);
+            case 65 -> Player.move(-1, 0);
+            case 68 -> Player.move(1, 0);
+            case 87 -> Player.move(0,-1);
+            case 83 -> Player.move(0,1);
         }
 
     }
@@ -49,6 +46,6 @@ private void update() {
     }
 
     public static void main(String[] args) {
-        PApplet.main("dungeon.App");
+        PApplet.main("dungeon.MainGame");
     }
 }

src/dungeon/Player.java

@@ -1,32 +1,45 @@
 package dungeon;
 
 import processing.core.PGraphics;
+import processing.core.PVector;
 
 public class Player {
-    private final String name;
-    private final PGraphics gfx;
-    private  int x;
-    private  int y;
-
-    public Player(String name, PGraphics gfx) {
-        this.name = name;
-        this.gfx = gfx;
-        x = 0;
-        y = 0;
+    private static Player playerInstance = null;
+
+    private static String name;
+
+    private static PGraphics gfx;
+
+    private static PVector direction;
+
+    private Player(String name, PGraphics gfx) {
+        Player.name = name;
+        Player.gfx = gfx;
+        direction = new PVector(0, 0);
     }
 
-    public void setPos(int x, int y) {
-        this.x = x;
-        this.y = y;
+    public static void getPlayerInstance(String playerName, PGraphics gfx) {
+        if (isNull()) {
+            playerInstance = new Player(playerName, gfx); // C'è una warning un po' bislacca
+        }
     }
 
-    public void draw() {
+    public static void setPos(int x, int y) {
+        direction.x = x;
+        direction.y = y;
+    }
+
+    public static void draw() {
         gfx.fill(255,0,0);
-        gfx.rect(x*16,y*16,16,16);
+        gfx.rect(direction.x*16,direction.y*16,16,16);
+    }
+
+    public static void move(int dx, int dy) {
+        direction.x += dx;
+        direction.y += dy;
     }
 
-    public void move(int dx, int dy) {
-        x += dx;
-        y += dy;
+    private static boolean isNull() {
+        return playerInstance == null;
     }
 }

src/dungeon/PlayerController.java

@@ -0,0 +1,5 @@
+package dungeon;
+
+public class PlayerController {
+    // work in progress...
+}