use Borrowed in extract_argument functions
#5695
Draft
+131
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress work to close #5392
I realised that using
Borrowedallows'ato outlive'pyin argument extraction. This is not always strictly necessary, but in the case of the async code I'm looking into in #5681 it turns out that it's valid for function arguments to have the'alifetime but not the'pylifetime.This might also be a performance help by removing the need to have references to pointers on stack frames for the
BoundRefstuff.