Skip to content

Conversation

@Lumabots
Copy link

Added explicit type annotations to test functions and variables for improved type safety and clarity. Refactored test predicates in test_find_util.py to named functions for better readability. Updated imports and variable declarations to use modern typing and collections. Minor cleanup in test_markdown_utils.py to remove unused imports.

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Added explicit type annotations to test functions and variables for improved type safety and clarity. Refactored test predicates in test_find_util.py to named functions for better readability. Updated imports and variable declarations to use modern typing and collections. Minor cleanup in test_markdown_utils.py to remove unused imports.
@Lumabots Lumabots requested a review from a team as a code owner September 29, 2025 15:27
@pycord-app
Copy link

pycord-app bot commented Sep 29, 2025

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/133/head:pr-133
git checkout pr-133

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord-next@refs/pull/133/head

@read-the-docs-community
Copy link

read-the-docs-community bot commented Sep 29, 2025

Documentation build overview

📚 pycord-next | 🛠️ Build #29783053 | 📁 Comparing 0d478c8 against latest (2e1025a)


🔍 Preview build

Show files changed (58 files in total): 📝 58 modified | ➕ 0 added | ➖ 0 deleted
File Status
api/abcs.html 📝 modified
api/clients.html 📝 modified
api/data_classes.html 📝 modified
api/exceptions.html 📝 modified
api/models.html 📝 modified
api/sinks.html 📝 modified
api/webhooks.html 📝 modified
_modules/discord/abc.html 📝 modified
_modules/discord/activity.html 📝 modified
_modules/discord/appinfo.html 📝 modified
_modules/discord/audit_logs.html 📝 modified
_modules/discord/bot.html 📝 modified
_modules/discord/channel.html 📝 modified
_modules/discord/client.html 📝 modified
_modules/discord/cog.html 📝 modified
_modules/discord/embeds.html 📝 modified
_modules/discord/enums.html 📝 modified
_modules/discord/errors.html 📝 modified
_modules/discord/flags.html 📝 modified
_modules/discord/guild.html 📝 modified
_modules/discord/integrations.html 📝 modified
_modules/discord/interactions.html 📝 modified
_modules/discord/invite.html 📝 modified
_modules/discord/member.html 📝 modified
_modules/discord/message.html 📝 modified
_modules/discord/object.html 📝 modified
_modules/discord/onboarding.html 📝 modified
_modules/discord/partial_emoji.html 📝 modified
_modules/discord/player.html 📝 modified
_modules/discord/poll.html 📝 modified
_modules/discord/raw_models.html 📝 modified
_modules/discord/role.html 📝 modified
_modules/discord/scheduled_events.html 📝 modified
_modules/discord/team.html 📝 modified
_modules/discord/threads.html 📝 modified
_modules/discord/utils.html 📝 modified
_modules/discord/welcome_screen.html 📝 modified
_modules/discord/widget.html 📝 modified
ext/commands/api.html 📝 modified
_modules/discord/commands/context.html 📝 modified
_modules/discord/commands/core.html 📝 modified
_modules/discord/commands/options.html 📝 modified
_modules/discord/ui/container.html 📝 modified
_modules/discord/ui/modal.html 📝 modified
_modules/discord/ui/section.html 📝 modified
_modules/discord/ui/select.html 📝 modified
_modules/discord/ui/view.html 📝 modified
_modules/discord/utils/public.html 📝 modified
modules/discord/webhook/async.html 📝 modified
_modules/discord/webhook/sync.html 📝 modified
_modules/discord/ext/bridge/context.html 📝 modified
_modules/discord/ext/bridge/core.html 📝 modified
_modules/discord/ext/commands/bot.html 📝 modified
_modules/discord/ext/commands/context.html 📝 modified
_modules/discord/ext/commands/converter.html 📝 modified
_modules/discord/ext/commands/core.html 📝 modified
_modules/discord/ext/commands/flags.html 📝 modified
_modules/discord/ext/commands/help.html 📝 modified

@plun1331
Copy link
Member

Added explicit type annotations to test functions and variables for improved type safety and clarity. Refactored test predicates in test_find_util.py to named functions for better readability. Updated imports and variable declarations to use modern typing and collections. Minor cleanup in test_markdown_utils.py to remove unused imports.

Summary

Not to nitpick, but the summary is supposed to go in the summary section

@Lumabots
Copy link
Author

Not to nitpick, but the summary is supposed to go in the summary section

i created the pull request from github desktop

@Lumabots Lumabots changed the title Add type annotations and refactor test utilities feat: Add type annotations and refactor test utilities Oct 1, 2025
@Paillat-dev Paillat-dev merged commit c085a07 into feat/tests Oct 1, 2025
6 of 7 checks passed
@Paillat-dev Paillat-dev deleted the strict-tests branch October 1, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants