feat: Timeout error now ignored #3018
Closed
+372
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the AppInfo.edit coroutine to allow editing application settings. Updates AppInfo and related types to support new fields such as bot, flags, event webhooks, integration_types_config, and approximate_user_authorization_count. Also refactors type hints and improves handling of optional fields for better API compatibility.
Introduces the AppInfo.edit() method to allow editing application settings, including new and previously missing fields such as icon, cover_image, tags, install_params, integration_types_config, flags, event_webhooks_url, event_webhooks_status, and event_webhooks_types. Also adds related helper classes and properties for handling these fields and updates the CHANGELOG accordingly.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Lumouille <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Lumouille <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Lumouille <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Lumouille <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Lumouille <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Lumouille <[email protected]>
Updated the AppInfo class to only accept bytes or None for the icon and cover_image parameters, removing support for str. This change clarifies the expected types and may prevent type-related errors.
…lify owner assignment
…atus and add setter for event_webhooks_enabled
Co-authored-by: Paillat <[email protected]> Signed-off-by: Lumouille <[email protected]>
Added mention of Paginator.on_timeout to the changelog entry about changed timeout behavior, clarifying that both BaseView and Paginator views no longer raise errors on timeout.
Lumabots
changed the title
Paillat-dev
requested changes
Dec 4, 2025
Member
Paillat-dev
left a comment
Paillat-dev
left a comment
There was a problem hiding this comment.
@Lumabots I think you mistakenly based this off of your appinfo pr
| - Added `Attachment.read_chunked` and added optional `chunksize` argument to | ||
| `Attachment.save` for retrieving attachments in chunks. | ||
| ([#2956](https://github.com/Pycord-Development/pycord/pull/2956)) | ||
| - Added `AppInfo.edit()` method and missing `AppInfo` fields. |
Signed-off-by: Lumouille <[email protected]>
…nt#3009) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…d-Development#3010) 📝 Fix versionadded for bypass slowmode permission to 2.7
…t#3007) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ent#3008) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…3005) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Lumouille <[email protected]>
Signed-off-by: Lumouille <[email protected]>
Contributor
Author
|
i spent the past 30min trying to rebase this out of appifno, im just gonna delete the branch and create a new one |
Member
|
Man.. Luma. Why do I have to wake up to that mess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently inside the on_timeout, if a message is deleted then it wil raise an error when trying to edit the message, this error is impossible to handle and so will just flood the console, lets rework this into ignoring it !
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.