-
Notifications
You must be signed in to change notification settings - Fork 8
Refactor backend #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor backend #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afshin
reviewed
Dec 13, 2024
afshin
reviewed
Dec 13, 2024
afshin
approved these changes
Dec 13, 2024
Member
afshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Afshin Taylor Darian <[email protected]>
Member
Author
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor backend functionalities to use
fsspec. Theobstorepackage was kept for certain functionalities as it has integrated pagination, so it is still used to list the contents given a path, retrieve contents of a file and get the presigned link of an object, while thefsspecpackage is used for creating, saving, renaming, copying and deleting.As a workaround for dealing with directories, they are created as objects having a key which ends with the suffix
/.jupyter-drives-fixDir. This way they will be hidden inside theDrivesFileBrowser, but users can still create, rename, copy and delete directorie.