Use TestSuite for orthnull #128
Open
+308
−811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
kshyatt
force-pushed
the
testsuite-orthnull
branch
3 times, most recently
from
4b6c91a to
b63c76c
Compare
kshyatt
force-pushed
the
testsuite-orthnull
branch
from
b63c76c to
58ecce8
Compare
lkdvos
reviewed
Dec 28, 2025
|
|
||
| M = LinearMap(A) | ||
| # broken | ||
| #VM, CM = @testinferred left_orth(M; alg = :svd) |
Member
There was a problem hiding this comment.
This is slightly annoying, but I think we could bypass this by defining a function in this file at toplevel like this:
_left_orth(x) = left_orth(x; alg = :svd)This should manually mimick what @constinferred would do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one could probably use some work on the tests themselves (trunc not really playing well with the GPU) and more algorithm tests