Skip to content

Conversation

@Jutho
Copy link
Member

@Jutho Jutho commented Dec 28, 2025

No description provided.

@codecov
Copy link

codecov bot commented Dec 28, 2025

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/yalapack.jl 0.00% 13 Missing ⚠️
Files with missing lines Coverage Δ
src/yalapack.jl 64.46% <0.00%> (+1.29%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jutho
Copy link
Member Author

Jutho commented Dec 28, 2025

@kshyatt , rescaling the eigenvalue distribution by a factor of 10 seems to solve the AD chainrules problems (for now) 🥳 .

@Jutho Jutho requested review from kshyatt and lkdvos December 28, 2025 23:42
Copy link
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, did you find these YALAPACK bugs through the new JET report? Otherwise we might have to also hunt for some extra test coverage at some point

@Jutho
Copy link
Member Author

Jutho commented Dec 29, 2025

Yes this is based on the new JET reports 😄 . However, it has issues with the pattern

if condition
    new_variable = 
else
    # no declaration/definition of new_variable
end
# more code
if same_condition_as_before
    do_something(new_variable)
end

And there also seem to be some compatibility issues with Julia LTS and newest JET.

@Jutho
Copy link
Member Author

Jutho commented Dec 29, 2025

Testing for all possible error messages is really a nuisance. Also, if there is a mistake in there, you will still get an error, only a less informative one 😄 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants