-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: retry computed qrl execution when not ready #7470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9efd287
feat(qrl): add QRL component and e2e test for inner computed QRL
726767b
Merge branch 'build/v2' into 7442_fix_promise_fail
JerryWu1234 b9fdb44
refactor(e2e): simplify test structure by removing unnecessary descri…
a60f42d
test(e2e): mark counter update test as .only for focused execution
29221ed
fix test fail
JerryWu1234 8e0fe55
feat(qrl): add QRL component and e2e test for inner computed QRL
8e3da40
refactor(e2e): simplify test structure by removing unnecessary descri…
08d5c64
test(e2e): mark counter update test as .only for focused execution
1459b13
fix test fail
JerryWu1234 b68c802
Merge branch '7442_fix_promise_fail' of https://github.com/JerryWu123…
JerryWu1234 2066991
add change
JerryWu1234 2fca63d
fix information
9d50c28
fix ts error
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { $, component$, useComputed$, useSignal } from "@qwik.dev/core"; | ||
|
|
||
| export const QRL = component$(() => { | ||
| return ( | ||
| <> | ||
| <ShouldResolveInnerComputedQRL /> | ||
| </> | ||
| ); | ||
| }); | ||
|
|
||
| export const ShouldResolveInnerComputedQRL = component$(() => { | ||
| const test = useComputed$(() => 0); | ||
| return <InnerComputedButton test={test} />; | ||
| }); | ||
|
|
||
| export const InnerComputedButton = component$<any>((props) => { | ||
| const syncSelectionCounter = useSignal(0); | ||
| const syncSelection = $(() => { | ||
| syncSelectionCounter.value++; | ||
| props.test.value; | ||
| }); | ||
|
|
||
| const handleClick = $(() => { | ||
| syncSelection(); | ||
| }); | ||
|
|
||
| return ( | ||
| <button id="inner-computed-button" onClick$={handleClick}> | ||
| Click Me {syncSelectionCounter.value} | ||
| </button> | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import { expect, test } from "@playwright/test"; | ||
| test("should update counter without uncaught promises", async ({ page }) => { | ||
| await page.goto("/e2e/qrl"); | ||
| page.on("pageerror", (err) => expect(err).toEqual(undefined)); | ||
| page.on("console", (msg) => { | ||
| if (msg.type() === "error") { | ||
| expect(msg.text()).toEqual(undefined); | ||
| } | ||
| }); | ||
| const button = page.locator("#inner-computed-button"); | ||
| await expect(button).toContainText("Click Me 0"); | ||
|
|
||
| // 先执行点击操作 | ||
JerryWu1234 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| await button.click(); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.