Skip to content

Conversation

@wmertens
Copy link
Member

@wmertens wmertens commented Apr 4, 2025

For some reason TS fails on this perfectly valid code

packages/docs/src/repl/repl-output-modules.tsx:58:44 - error TS18048: 'o.shorten' is possibly 'undefined'.

58                   <button onClick$={() => (o.shorten.value = !o.shorten.value)}>
                                              ~~~~~~~~~

packages/docs/src/repl/repl-output-modules.tsx:58:63 - error TS18048: 'o.shorten' is possibly 'undefined'.

58                   <button onClick$={() => (o.shorten.value = !o.shorten.value)}>
                                                                 ~~~~~~~~~


Found 2 errors in the same file, starting at: packages/docs/src/repl/repl-output-modules.tsx:58


❌  Error: Command failed with exit code 2: tsc -p packages/docs/tsconfig.json
    at makeError (file:///home/wmertens/Projects/qwik/node_modules/.pnpm/[email protected]/node_modules/execa/lib/error.js:60:11)
    at handlePromise (file:///home/wmertens/Projects/qwik/node_modules/.pnpm/[email protected]/node_modules/execa/index.js:124:26)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async tscDocs (/home/wmertens/Projects/qwik/scripts/tsc-docs.ts:8:18)
    at async build (/home/wmertens/Projects/qwik/scripts/build.ts:147:7) {

@wmertens wmertens requested a review from a team as a code owner April 4, 2025 20:58
@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2025

⚠️ No Changeset found

Latest commit: a9e6df2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wmertens wmertens enabled auto-merge (squash) April 4, 2025 20:58
@wmertens wmertens merged commit 7276ed6 into QwikDev:main Apr 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants