Skip to content

Conversation

@zaynet
Copy link
Contributor

@zaynet zaynet commented Apr 7, 2025

What is it?

  • Docs / tests / types / typos

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@zaynet zaynet requested review from a team as code owners April 7, 2025 14:17
@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2025

⚠️ No Changeset found

Latest commit: 6ed4e22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gioboa
gioboa previously approved these changes Apr 7, 2025
PatrickJS
PatrickJS previously approved these changes Apr 7, 2025
thejackshelton
thejackshelton previously approved these changes Apr 7, 2025
Copy link
Member

@thejackshelton thejackshelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thejackshelton
Copy link
Member

image

@PatrickJS PatrickJS dismissed stale reviews from thejackshelton and themself via 6ed4e22 April 7, 2025 23:23
@PatrickJS PatrickJS enabled auto-merge (squash) April 7, 2025 23:24
@PatrickJS PatrickJS merged commit 2d2d9a4 into QwikDev:main Apr 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants