Skip to content

Conversation

@JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Apr 11, 2025

What is it?

fixes: #7394

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested review from a team as code owners April 11, 2025 07:17
@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2025

🦋 Changeset detected

Latest commit: 64d1c89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 11, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7510
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7510
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7510
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7510

commit: 64d1c89

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 64d1c89

@JerryWu1234
Copy link
Contributor Author

@Varixo done it,

@JerryWu1234 JerryWu1234 self-assigned this Apr 14, 2025
@JerryWu1234 JerryWu1234 requested a review from Varixo April 14, 2025 07:30
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good but requires exporting from public.d.ts

@JerryWu1234
Copy link
Contributor Author

@wmertens done it

@gioboa gioboa requested a review from wmertens May 2, 2025 12:26
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 7968493 into QwikDev:build/v2 May 6, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants