Skip to content

Conversation

@JerryWu1234
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested a review from a team as a code owner December 12, 2025 01:49
@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2025

⚠️ No Changeset found

Latest commit: 41e1976

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JerryWu1234 JerryWu1234 requested a review from wmertens December 12, 2025 01:50
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, are we importing it in any file?

@JerryWu1234
Copy link
Contributor Author

Thanks, are we importing it in any file?

the Root file in library mode with creating via pnpm create is linking global css

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 41e1976

@gioboa
Copy link
Member

gioboa commented Dec 12, 2025

the Root file in library mode with creating via pnpm create is linking global css

👀 This file doesn't have the import 🤔

build/v2 file has it 👍

@gioboa
Copy link
Member

gioboa commented Dec 12, 2025

Usually it inherited the one form the base folder though 🤔

@JerryWu1234
Copy link
Contributor Author

Usually it inherited the one form the base folder though 🤔

actually no.
In create-qwik, library is handled as a special case: when the selected starter id is "library", it returns { baseApp: libApp } and does not merge base + starterApp. As a result, starters/apps/base/src/global.css is not copied into a library project automatically.

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @JerryWu1234

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 12, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8202
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8202
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8202
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8202

commit: 41e1976

@gioboa gioboa merged commit 86e8beb into QwikDev:build/v2 Dec 12, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants