Skip to content

Conversation

@ammallya
Copy link
Contributor

@ammallya ammallya commented Dec 3, 2025

Motivation

Automate bumping of rocm-libraries PR daily

Progress on #223

@ammallya ammallya marked this pull request as draft December 3, 2025 17:45
@ammallya ammallya marked this pull request as ready for review December 3, 2025 18:23
@mgehre-amd
Copy link
Contributor

We had some good results enabling auto merge (via the gh tool) on the bump PRs, so they would merge after CI checks are green.

@ScottTodd
Copy link
Member

We had some good results enabling auto merge (via the gh tool) on the bump PRs, so they would merge after CI checks are green.

In which repository? Here in TheRock the only required check right now is pre-commit, so auto-merge won't wait for non-required CI checks. I would certainly like for auto-merge to be something we can safely enable if we can get our build/test/etc. times down to 30-60 minutes.

@ammallya
Copy link
Contributor Author

ammallya commented Dec 5, 2025

#2448 Sample PR created by new changes

@ammallya ammallya requested a review from ScottTodd December 5, 2025 20:30
Comment on lines +41 to +44
run: |
python3 ./build_tools/bump_submodules.py --push-branch \
--branch-name ${{ steps.set-branch.outputs.branch-name }} \
--components rocm-libraries"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing " on the last line here? Remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was waiting on the final go ahead to fix all the pre-commit issues.

@ammallya
Copy link
Contributor Author

ammallya commented Dec 8, 2025

ammallya#2 New sample PR with commit message fixed to match title

@ammallya ammallya requested a review from ScottTodd December 8, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

4 participants