-
Notifications
You must be signed in to change notification settings - Fork 142
Automation to bump rocm-libraries submodule daily #2401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
We had some good results enabling auto merge (via the gh tool) on the bump PRs, so they would merge after CI checks are green. |
In which repository? Here in TheRock the only required check right now is pre-commit, so auto-merge won't wait for non-required CI checks. I would certainly like for auto-merge to be something we can safely enable if we can get our build/test/etc. times down to 30-60 minutes. |
|
#2448 Sample PR created by new changes |
| run: | | ||
| python3 ./build_tools/bump_submodules.py --push-branch \ | ||
| --branch-name ${{ steps.set-branch.outputs.branch-name }} \ | ||
| --components rocm-libraries" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing " on the last line here? Remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was waiting on the final go ahead to fix all the pre-commit issues.
|
ammallya#2 New sample PR with commit message fixed to match title |
Motivation
Automate bumping of rocm-libraries PR daily
Progress on #223