Align package.json with RFC0009 packaging spec #2414
Conversation
nunnikri
left a comment
nunnikri
left a comment
There was a problem hiding this comment.
Looks good. Need to take care of the comments.
| "rocm-core" | ||
| "DEBRecommends": [ | ||
| "python3-argcomplete", | ||
| "amdrocm-sysdeps" |
There was a problem hiding this comment.
Since libdrm requirement is there for amd-smi, shouldnt sysdeps a requires rather than recommends?
There was a problem hiding this comment.
ROCm amdsmi package doesn't have any dependency to libdrm. Only recommends shows the same.
Can we add libdrm as a dependency?
| "libc6" | ||
| ], | ||
| "RPMRequires": [ | ||
| "libgcc", | ||
| "libstdc++", | ||
| "python3", | ||
| "glibc" |
There was a problem hiding this comment.
Need to add amdrocm-runtime and python3 as dependency.
There was a problem hiding this comment.
Added amdrocm-runtime and amdrocm-sysdeps ,
Python doesn't seems to a dependeny for rocm-fft
| "libc6", | ||
| "amd-llvm" | ||
| "amdrocm-runtime", | ||
| "amdrocm-profiler-base" |
There was a problem hiding this comment.
rocsolver can be added as recommneds
| }, | ||
|
|
||
| { | ||
| "Package": "rocm-miopen-devel", | ||
| "Package": "amdrocm-hipblas-common-devel", |
There was a problem hiding this comment.
hipblas-common should be part of amdrocm-blas
| }, | ||
|
|
||
| { | ||
| "Package": "rocm-sysdeps", | ||
| "Package": "amdrocm-rccl", |
There was a problem hiding this comment.
We might have to move this to rocm-base based on BU feedback
raramakr
changed the title
This change updates package.json to include the packages required by RFC0008-OS-Packaging-Requirements. TODO: The removed package details can be saved in a separate JSON file and reused to generate ROCm packages if required.
All package name starts with amdrocm Updated the dependencies
…age.json Updated package dependencies as well
raramakr
force-pushed
the
users/raramakr/packaging
branch
from
a05704b to
e408691
Compare
This change updates package.json to include the packages required by RFC0009-OS-Packaging-Requirements.
TODO: The removed package details can be saved in a separate JSON file and reused to generate ROCm packages if required.