Skip to content

Conversation

@dorde-antic
Copy link
Contributor

@dorde-antic dorde-antic commented Nov 24, 2025

Motivation

Resolves known problems we have in MITuna until we fix them on MITuna so that our CI doesn't get blocked for dtypes problems...

Technical Details

Expand configs with undefined dtypes to allowed WMMA ones for attention

Test Plan

Tuning Attention

(Commit: 3d9f673 - with embedded py script right before tuning attn)
https://ml-ci-internal.amd.com/blue/organizations/jenkins/MLIR%2Fmlir/detail/PR-2123/5/pipeline/667 (fails for other reasons)

(Commit: f3322d2 - after moving filtering logic in groovy function)
https://ml-ci-internal.amd.com/job/MLIR/job/mlir/job/PR-2123/

Test Result

Submission Checklist

@dorde-antic
Copy link
Contributor Author

dorde-antic commented Dec 3, 2025

@umangyadav @dhernandez0
https://ml-ci-internal.amd.com/blue/organizations/jenkins/MLIR%2Fmlir/detail/PR-2123/5/pipeline/698
by this way of handling configs without datatype defined, there are no f32 tried for attn on navi in CI. (the present errors in run I've pasted here are not related to tuning f32)

We can move this expanding logic (which i tried directly in Jenkinsfile) for example to handleNewConfigs script (or other script used in CI) and call that function in CI before tuning attn on navi? Then we would reuse defined dtypes from perfRunner in handleNewConfigs, and it won't be hardcoded as in case I did in Jenkinsfile direclty in this PR (did it like that for testing purposes)

@dhernandez0
Copy link
Contributor

@umangyadav @dhernandez0 https://ml-ci-internal.amd.com/blue/organizations/jenkins/MLIR%2Fmlir/detail/PR-2123/5/pipeline/698 by this way of handling configs without datatype defined, there are no f32 tried for attn on navi in CI. (the present errors in run I've pasted here are not related to tuning f32)

We can move this expanding logic (which i tried directly in Jenkinsfile) for example to handleNewConfigs script (or other script used in CI) and call that function in CI before tuning attn on navi? Then we would reuse defined dtypes from perfRunner in handleNewConfigs, and it won't be hardcoded as in case I did in Jenkinsfile direclty in this PR (did it like that for testing purposes)

I'm happy with this solution as a temporary fix until we find how to properly fix it.

@dorde-antic dorde-antic marked this pull request as ready for review December 4, 2025 13:24
@dorde-antic dorde-antic requested a review from causten as a code owner December 4, 2025 13:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the Jenkins pipeline to handle attention configurations for gfx1 chips by expanding entries without explicit dtypes to include all allowed WMMA data types (i8, f16, bf16), while filtering out f32 configurations.

Key Changes:

  • Replaces simple grep filtering with a Python script that processes attention configuration files
  • Expands configuration entries lacking explicit -t dtype flags to multiple entries with each allowed dtype
  • Preserves comments and empty lines in the configuration file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@umangyadav
Copy link
Member

i am okay with keeping logic here in jenkinsfile but drawback is that we have to keep same logic in multiple different places now.

@dorde-antic
Copy link
Contributor Author

i am okay with keeping logic here in jenkinsfile but drawback is that we have to keep same logic in multiple different places now.

Once I finish resolving it on MITuna we can remove redundant code for this
@umangyadav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants