-
Notifications
You must be signed in to change notification settings - Fork 50
Set default value of causal, return_lse and with-attn-* to false #2141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modifies the attention configuration generation to reduce tuning time by setting default values for causal, return_lse, with-attn-scale, and with-attn-bias parameters to false when they are not explicitly specified in the problem configuration. This is a performance optimization that reduces the configuration search space by avoiding unnecessary testing of these feature combinations.
Key Changes
- Changed four attention parameters in the default test space from
bool_space(['false', 'true']) todefault_to_false(['false']), effectively reducing the number of generated test configurations - Added a comment explaining that undefined parameters should default to false
- This aligns with existing defaults in
AttentionConfiguration.from_command_line()and matches common usage patterns seen in tier1-attention-configs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Motivation
To avoid really long tuning time, we can set the default value of these params to false. I think if migraphx didn't provide those, it's a safe assumption that they are false.
Please, review MITuna PR as well: ROCm/MITuna#1015
Technical Details
Just set the value to false if they are not in the problem config.
Test Plan
All tests pass.
Test Result
All tests pass.
Submission Checklist