SWDEV-567545 - Implement block_rank in co-op grid groups #2182
+59
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiabaxie
force-pushed
the
amd/dev/jiabaxie/SWDEV-567545
branch
from
47c3927 to
c76cada
Compare
Copilot finished reviewing on behalf of
jiabaxie
December 4, 2025 22:00
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the block_rank() method for cooperative group types (grid_group, multi_grid_group, and thread_block), which returns the rank/index of the block containing the calling thread. The implementation adds both the helper functions and the public API methods, along with a test for grid_group.
Key changes:
- Added
block_rank()implementations in the cooperative groups helper namespace (grid and workgroup) - Exposed
block_rank()API for grid_group, multi_grid_group, and thread_block classes - Added test coverage for grid_group.block_rank()
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/clr/hipamd/include/hip/amd_detail/hip_cooperative_groups_helper.h | Added block_rank() helper functions for grid and workgroup namespaces to compute block linearization |
| projects/clr/hipamd/include/hip/amd_detail/amd_hip_cooperative_groups.h | Exposed block_rank() method in grid_group, multi_grid_group, and thread_block classes |
| projects/hip-tests/catch/unit/cooperativeGrps/grid_group.cc | Added test kernel and validation for grid_group.block_rank() |
| projects/hip-tests/catch/unit/CMakeLists.txt | All subdirectory entries removed except cooperativeGrps (appears to be accidental) |
| projects/hip-tests/catch/include/utils.hh | Test assertion statements commented out (breaks test validation) |
| projects/clr/CHANGELOG.md | Added documentation for the new block_rank() support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
projects/clr/hipamd/include/hip/amd_detail/amd_hip_cooperative_groups.h
Outdated
Show resolved
Hide resolved
projects/clr/hipamd/include/hip/amd_detail/amd_hip_cooperative_groups.h
Outdated
Show resolved
Hide resolved
projects/clr/hipamd/include/hip/amd_detail/amd_hip_cooperative_groups.h
Outdated
Show resolved
Hide resolved
jiabaxie
force-pushed
the
amd/dev/jiabaxie/SWDEV-567545
branch
from
c798c4a to
265db06
Compare
jiabaxie
force-pushed
the
amd/dev/jiabaxie/SWDEV-567545
branch
from
265db06 to
1bf63e9
Compare
Copilot finished reviewing on behalf of
jiabaxie
December 4, 2025 22:50
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jiabaxie
force-pushed
the
amd/dev/jiabaxie/SWDEV-567545
branch
from
1bf63e9 to
15d7233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To implement block_rank feature
Technical Details
block_rank() is callable from grid group
JIRA ID
SWDEV-567545
Test Plan
Test written in this PR
Test Result
Test pass
Submission Checklist