SWDEV-548892 - Stop using __ockl_lane_id #2186
Open
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__lane_id already exists and is identical.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces all usages of the deprecated __ockl_lane_u32() function with the equivalent __lane_id() function across HIP device code and tests. The __lane_id() function is functionally identical but represents the preferred API going forward.
- Replaced
__ockl_lane_u32()with__lane_id()in warp sync functions - Updated performance test code to use the new lane ID function
- Refactored test to cache lane ID in a local variable to avoid redundant calls
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/hip-tests/catch/performance/warpSync/warpSync.cc | Updated test kernels to use __lane_id() and introduced local variable to cache lane ID |
| projects/clr/hipamd/include/hip/amd_detail/amd_warp_sync_functions.h | Replaced __ockl_lane_u32() with __lane_id() in reduce operation sync function |
| projects/clr/hipamd/include/hip/amd_detail/amd_device_functions.h | Updated lane mask utility functions to use __lane_id() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kzhuravl
approved these changes
Dec 4, 2025
fabiomestre
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__lane_id already exists and is identical.