Rock: hip-tests installation path to remain same for linux/windows #2187
+53
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On theRock - installation path remains same linux/windows share/hip/catch_tests On internal win build - hip-tests will be installed to catch_tests flag is passed internally which controls the path.
removed the else part
agunashe
changed the title
This was referenced Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On theRock - installation path remains same linux/windows as share/hip/catch_tests
On internal win build - hip-tests will be installed to catch_tests depending on a flag that is passed internally from amd_build.py script
Motivation
hip-tests installation paths were different before since there was no requirement.
This PR aligns linux and windows to have same path
Technical Details
hip-tests installation paths were different before since there was no requirement.
This PR aligns linux and windows to have same path since Rock is a common setup.
JIRA ID
SWDEV-566268
Test Plan
hip-tests built and passes rocm-ci and windows builds
Test Result
NA
Submission Checklist