-
Notifications
You must be signed in to change notification settings - Fork 13
chore!: Update blockly-keyboard-experimentation for Blockly v12. #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I would recommend you mark this as a breaking change since you are updating the minimum peer dependency on blockly. It will make it easier to know which is the latest safe version for folks that aren't using v12 yet. I don't know how strict you're being about versioning though. |
|
This PR requires you to use Some options:
|
|
I think we should remove the colour field and its uses so that we don't require |
|
github needs to let me emoji react to commits already - glad the overrides worked! |
This PR fixes #301 by updating the keyboard experimentation plugin to use and depend on Blockly v12.