feat: paste in move mode #479
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Share insert code with flyout insert. Closes RaspberryPiFoundation#478
microbit-matt-hillsdon
requested review from
RoboErikG
and removed request for
a team
Contributor
Author
|
I found #476 while testing this but it predates this change. |
Contributor
|
Code looks good overall, but for now lets go with placing the block instead of putting it in move mode both to be consistent with other editors and so it doesn't cause issues with using a mouse for copy/pasting. |
RoboErikG
suggested changes
Apr 30, 2025
Contributor
RoboErikG
left a comment
RoboErikG
left a comment
There was a problem hiding this comment.
Please update to place the block instead of leaving in move mode.
Contributor
Author
|
Thanks @RoboErikG, I agree this needs more thought for the impact on mouse users and it looks like we have copy/paste input inbound from user testing so I'll park this one for a bit until I get my head around that. |
Contributor
Author
|
Closing in favour of keeping paste more like regular Blockly as on #501. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share insert code with flyout insert.
This aligns top level block placement too.
Potentially we use the same approach for Duplicate too.
Closes #478