feat(mover): Report keyboard moves to WorkspaceSvg
#485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call Workspace.prototype.setKeyboardMoveInProgress at the beginning and end of each keyboard-initiated move.
cpcallen
changed the title
WorkspaceSvg
rachel-fenichel
requested changes
May 2, 2025
Collaborator
rachel-fenichel
left a comment
rachel-fenichel
left a comment
There was a problem hiding this comment.
You also need to look at patchWorkspace and unpatchWorkspace to remove all monkeypatches that this replaces. You may be able to delete both functions entirely.
Collaborator
Author
|
I believe this is ready for re-review. Tests are failing due to an unrelated breaking change in RaspberryPiFoundation/blockly#8917 causing code in |
rachel-fenichel
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
Workspace.prototype.setKeyboardMoveInProgressat the beginning and end of each keyboard-initiated move.Complementary to RaspberryPiFoundation/blockly#8874.
Depends on RaspberryPiFoundation/blockly#8959.