fix: remove calls to cursor.hide #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Collaborator
Author
|
Ready for review now that RaspberryPiFoundation/blockly#8962 landed. |
maribethb
approved these changes
May 7, 2025
Collaborator
maribethb
left a comment
maribethb
left a comment
There was a problem hiding this comment.
Are we planning to keep these enable/disable methods? I thought we didn't want them. Or maybe we want them in the plugin but makecode will just never use them?
Collaborator
Author
|
I think we will delete them entirely as a companion to RaspberryPiFoundation/blockly#8924. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of RaspberryPiFoundation/blockly#8962
Related to RaspberryPiFoundation/blockly#8924
The keyboard navigation plugin currently explicitly turns keyboard mode on and off, and that includes explicitly hiding the cursor. After RaspberryPiFoundation/blockly#8924 we will use CSS to control whether active and passive focus are visible, and updating that CSS will be done by the new
KeyboardNavigationController.