chore: Fix and enable field navigation unit tests. #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| testSetup, | ||
| } from './test_setup.js'; | ||
|
|
||
| suite.only('Insert test', function () { |
Contributor
There was a problem hiding this comment.
Oops!
Would need a separate run step for CI vs local to sanity check this but might be worth it.
Contributor
|
#512 should fix the build errors you're seeing. |
RoboErikG
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many test methods had been disabled. In fact, only one of them was actually running (because it called
suite.only()). I re-enabled most of the tests, adapted them to the current behavior, and temporarily reverted one line intest_setup.tstocallgetCursor()?.setCurNode(field)instead offield.getFocusableElement()?.focus()because the latter doesn't work yet and I figure it would be more useful for the tests to be functional and enabled.EDIT: Whoops, it looks like existing code in this repo was broken by RaspberryPiFoundation/blockly#9016 so github's automated test run fails for reasons that aren't related to my changes.