chore: Added context menu item tests. #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnesky
force-pushed
the
nesky_menu_tests
branch
from
17bd9b7 to
6779e2f
Compare
cpcallen
reviewed
Jun 13, 2025
johnnesky
force-pushed
the
nesky_menu_tests
branch
4 times, most recently
from
f29c7db to
4832ab3
Compare
RoboErikG
approved these changes
Jul 28, 2025
Contributor
RoboErikG
left a comment
RoboErikG
left a comment
There was a problem hiding this comment.
Tests look good. One suggestion about making it easier to update the expected menu items.
johnnesky
force-pushed
the
nesky_menu_tests
branch
from
4832ab3 to
5d18ad3
Compare
johnnesky
force-pushed
the
nesky_menu_tests
branch
from
6e57525 to
18ea5f0
Compare
johnnesky
force-pushed
the
nesky_menu_tests
branch
from
18ea5f0 to
a8cc795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the unit tests described in https://docs.google.com/document/d/1pIIX5sKEG9f_NcWDIQJJEOMM7w7pQUf8eJoT3lrAElQ for context menu items in various situations.
The set of expected available context menu items depends on the focused object, whether it's in a flyout, and how the menu was opened. The tests are currently configured to expect the set of menu items that the currently implemented behavior produces.