Skip to content

refactor(tests): Remove unneeded tabNavigateToWorkspace calls #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
Merged

refactor(tests): Remove unneeded tabNavigateToWorkspace calls #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/webdriverio/test/duplicate_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ suite('Duplicate test', function () {

test('Duplicate block', async function () {
// Navigate to draw_circle_1.
await tabNavigateToWorkspace(this.browser);
await focusOnBlock(this.browser, 'draw_circle_1');

// Duplicate
Expand Down
2 changes: 0 additions & 2 deletions test/webdriverio/test/insert_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ suite('Insert test', function () {

test('Insert and cancel with block selection', async function () {
// Navigate to draw_circle_1.
await tabNavigateToWorkspace(this.browser);
await focusOnBlock(this.browser, 'draw_circle_1');
// Insert 'if' block
await sendKeyAndWait(this.browser, 't');
Expand Down Expand Up @@ -70,7 +69,6 @@ suite('Insert test', function () {

test('Insert C-shaped block with statement block selected', async function () {
// Navigate to draw_circle_1.
await tabNavigateToWorkspace(this.browser);
await focusOnBlock(this.browser, 'draw_circle_1');

await moveToToolboxCategory(this.browser, 'Functions');
Expand Down
4 changes: 0 additions & 4 deletions test/webdriverio/test/move_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import {Browser, Key} from 'webdriverio';
import {
PAUSE_TIME,
focusOnBlock,
tabNavigateToWorkspace,
testFileLocations,
testSetup,
sendKeyAndWait,
Expand All @@ -36,7 +35,6 @@ suite('Move tests', function () {
test('Start moving statement blocks', async function () {
for (let i = 1; i < 7; i++) {
// Navigate to statement_<i>.
await tabNavigateToWorkspace(this.browser);
await focusOnBlock(this.browser, `statement_${i}`);

// Get information about parent connection of selected block,
Expand Down Expand Up @@ -96,7 +94,6 @@ suite('Move tests', function () {
test('Start moving value blocks', async function () {
for (let i = 1; i < 7; i++) {
// Navigate to statement_<i>.
await tabNavigateToWorkspace(this.browser);
await focusOnBlock(this.browser, `value_${i}`);

// Get information about parent connection of selected block,
Expand Down Expand Up @@ -166,7 +163,6 @@ suite('Move tests', function () {
});

// Navigate to unconnectable block, get initial coords and start move.
await tabNavigateToWorkspace(this.browser);
await focusOnBlock(this.browser, BLOCK);
const startCoordinate = await getCoordinate(this.browser, BLOCK);
await sendKeyAndWait(this.browser, 'm');
Expand Down
3 changes: 0 additions & 3 deletions test/webdriverio/test/mutator_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
testSetup,
testFileLocations,
PAUSE_TIME,
tabNavigateToWorkspace,
sendKeyAndWait,
keyRight,
keyDown,
Expand All @@ -29,8 +28,6 @@ suite('Mutator navigation', function () {
setup(async function () {
this.browser = await testSetup(testFileLocations.NAVIGATION_TEST_BLOCKS);
this.openMutator = async () => {
await tabNavigateToWorkspace(this.browser);
await this.browser.pause(PAUSE_TIME);
await focusOnBlock(this.browser, 'controls_if_1');
await this.browser.pause(PAUSE_TIME);
// Navigate to the mutator icon
Expand Down
3 changes: 0 additions & 3 deletions test/webdriverio/test/styling_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ suite('Styling test', function () {
});

test('Workspace has only active tree style when move is in progress', async function () {
await tabNavigateToWorkspace(this.browser);
await focusOnBlock(this.browser, 'set_background_color_1');
// Moves block to drag layer which requires different selectors.
await sendKeyAndWait(this.browser, 'm');
Expand All @@ -91,7 +90,6 @@ suite('Styling test', function () {
});

test('Workspace has only active tree style when widget has focus', async function () {
await tabNavigateToWorkspace(this.browser);
await focusOnBlock(this.browser, 'create_canvas_1');
// Move to field.
await keyRight(this.browser);
Expand All @@ -103,7 +101,6 @@ suite('Styling test', function () {
});

test('Workspace has only active tree style when dropdown has focus', async function () {
await tabNavigateToWorkspace(this.browser);
await focusOnBlock(this.browser, 'set_background_color_1');
// Move to color block.
await keyRight(this.browser);
Expand Down
Loading