feat: Add labels for Toolbox and Flyout content containers (experimental)
#9483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: feature
BenHenning
commented
Nov 26, 2025
Collaborator
Author
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Spot check on code.
Mac CI failures seem to be existing but there are more than I'm used to seeing. I don't see why this change would cause any new issues, and the tests are still passing on Linux so this is likely not affecting those tests.
Collaborator
Author
|
PTAL @maribethb. /cc @microbit-robert in case you wanted to re-check this on the micro:bit side. |
1 task
1 task
Contributor
|
@BenHenning LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9464
Proposed Changes
Adds ARIA labels for
ToolboxandFlyout('sWorkspace) containers to complement their existing region labels.Reason for Changes
In some cases certain screen readers (like NVDA) don't read out region labels. Previously, only the region labels provided context for currently being within the toolbox or flyout, so adding additional labels on the ARIA
treecontainers themselves ensures that these contexts are always read if the tree's context is read.This adds redundancy with the region output if both are read, but ChromeVox at least adds some delay between finishing the tree's context and beginning the region's context and this seems to mesh well together. The fully read context now feels like: "here's an item, it's the toolbox tree, and that tree is within the toolbox region." Even though both regions only contain a single tree it doesn't feel dimorphic.
Test Coverage
No new automated tests are needed for this experimental change.
This has been manually tested with ChromeVox to demonstrate the dual tree + region output for both toolbox and flyout:
Screen.recording.2025-11-26.2.52.22.PM.webm
Documentation
No new documentation is needed for this experimental change.
Additional Information
This was only tested on ChromeVox.