-
Notifications
You must be signed in to change notification settings - Fork 11
[CC Projects] Lines are sometimes off by one line #1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
0158e4e
74c7d6f
991dfe5
4633ddf
8774530
3f41dbd
31e77d5
31a2a76
c62121d
57f18cf
5ce71f6
f94ce52
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| $font-family-sans-serif: Roboto, -apple-system, BlinkMacSystemFont, 'Segoe UI', Oxygen, Ubuntu, Cantarell, 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif; | ||
| $font-family-monospace: RobotoMono, source-code-pro, Menlo, Monaco, Consolas, "Courier New", monospace; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My only concern with this is that it might change the fonts we're using in places like within codemirror, as we were using different monospace fonts in different places - maybe that's okay though?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This does indeed change the fonts within codemirror and other places to a standard set. I'm not sure we necessarily need all these fonts to fall back through. It does mean we have a consistent treatment of fonts through the interface now. They can also be customised by the new CSS variables so that in individual applications (e.g. code club projects) a different font could be used.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll try and sort out some screenshots of the codemirror change in the projects site UI |
||
Uh oh!
There was an error while loading. Please reload this page.