Skip to content

Conversation

@xiangce
Copy link
Contributor

@xiangce xiangce commented Oct 29, 2025

  • Command: "keyctl show %:.platform"
  • Jira: RHINENG-21020
  • No parser is required

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?
  • Need backport to 3.0_egg? Yes, refer to RPM/Egg Delivery to open a new PR.
  • Is this a backport from master? Yes, this is a backport of #PR-ID

Complete Description of Additions/Changes:

Add your description here

Summary by Sourcery

Add a new spec keyctl_show to collect the output of the "keyctl show %:.platform" command

Enhancements:

  • Register keyctl_show in the Specs registry
  • Define default simple_file spec for "/usr/bin/keyctl show %:.platform" collecting un-obfuscated host data

@xiangce xiangce added SPEC Change needs SPEC approval data collection Changes that would impact the data collection RPM RPM package related only. labels Oct 29, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduces a new analytics spec keyctl_show by registering it in the spec set and defining its default simple_file command without requiring a parser.

File-Level Changes

Change Details Files
Register new spec keyctl_show in the Specs registry
  • Added a RegistryPoint entry for keyctl_show
  • Configured obfuscation exemptions (hostname, ipv4, ipv6, mac)
insights/specs/__init__.py
Define default simple_file spec for keyctl_show
  • Added simple_file mapping for the keyctl show command
  • Used platform placeholder in the command path
insights/specs/default.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.34%. Comparing base (2b5017e) to head (0a937f2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4611   +/-   ##
=======================================
  Coverage   89.33%   89.34%           
=======================================
  Files         723      723           
  Lines       33394    33396    +2     
  Branches     4960     4960           
=======================================
+ Hits        29834    29838    +4     
+ Misses       2839     2838    -1     
+ Partials      721      720    -1     
Flag Coverage Δ
unittests 89.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Command: "keyctl show %:.platform"
- Jira: RHINENG-21020
- No parser is required

Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data collection Changes that would impact the data collection RPM RPM package related only. SPEC Change needs SPEC approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants