Support custom conversions for the mapped Item fields #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniycheban
force-pushed
the
gh-115
branch
2 times, most recently
from
8545f83 to
2b92cbd
Compare
Member
Author
|
I changed it to draft to solve one design issue. |
Member
Author
It is ready for review. |
Contributor
|
Thanks |
evgeniycheban
force-pushed
the
gh-115
branch
5 times, most recently
from
fcb529d to
2475768
Compare
Contributor
|
Is the problem that PR solves relevant to the project? Is there compatibility with hibernate in the project roadmap? |
Contributor
|
It would be great to split one big commit into several atomic ones. It would be easier to review. |
steleal
reviewed
May 13, 2025
src/main/java/ru/rt/restream/reindexer/convert/GenericFieldConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/rt/restream/reindexer/convert/FieldConverterRegistryFactory.java
Show resolved
Hide resolved
src/main/java/ru/rt/restream/reindexer/convert/FieldConverterRegistryFactory.java
Show resolved
Hide resolved
src/main/java/ru/rt/restream/reindexer/convert/FieldConverterRegistryFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/rt/restream/reindexer/convert/FieldConverterRegistryFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/ru/rt/restream/reindexer/convert/util/ConversionUtils.java
Outdated
Show resolved
Hide resolved
- Added custom conversion api Closes Restreamgh-115
- Implemented resolution of convertible types Closes Restreamgh-115
- Implemented FieldConverterRegistryFactory - Exposed custom conversion api in ReindexerConfiguration Closes Restreamgh-115
- Reconsidered internal mappings to use custom conversion api - Implemented CollectionUtils to map various collection types Closes Restreamgh-115
evgeniycheban
changed the title
- Added tests Closes Restreamgh-115
steleal
approved these changes
May 22, 2025
MadSchemas
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-115