Band-aid fix to strip erroneous length byte and CRC from client payload #3036
+29
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of code in
cmdhffelica.cwas doing one of the following:AddCrcto the frame data, while also settingFELICA_APPEND_CRCwhich causes CRC to be appended by the ARM side.felica_sendraw. This issue also compounded if extra CRC was sent due to 1).This PR does the following to fix the issue:
AddCrcin client code, instead using FELICA_ADD_CRC.clear_and_send_commandto check if first byte of the payload looks like length, removing it if it is.The fix was tested with the following commands (with client and ARM built on macOS using clang):