Feature/latency benchmarking #2461
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiple Registrys being created? possibly cpp rule of 5
…to use for later data analysis
Contributor
|
hmmmmmm |
Squid5678
requested changes
Nov 17, 2025
Contributor
Squid5678
left a comment
Squid5678
left a comment
There was a problem hiding this comment.
couple of cleanup things, otherwise looks good
src/rj_benchmarking/include/rj_benchmarking/registry_publisher.hpp
Outdated
Show resolved
Hide resolved
automated style fixes Co-authored-by: yuvrajdhadwal <[email protected]>
rishiso
requested changes
Nov 17, 2025
src/rj_benchmarking/include/rj_benchmarking/registry_publisher.hpp
Outdated
Show resolved
Hide resolved
src/rj_benchmarking/include/rj_benchmarking/registry_publisher.hpp
Outdated
Show resolved
Hide resolved
…oJackets/robocup-software into feature/latency_benchmarking
automated style fixes Co-authored-by: yuvrajdhadwal <[email protected]>
Squid5678
approved these changes
Nov 19, 2025
Contributor
Squid5678
left a comment
Squid5678
left a comment
There was a problem hiding this comment.
small nit otherwise looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a pluggable RAII Timer object that starts timer at construction and ends timer at object destruction. Will show up in session csv file for future latency analysis.
Steps to Test
#include <rj_benchmarking/timer.hpp>Timer t("timer_label", robot_id);